[CHIA-3419] Remove TransactionRecord.*_json_dict_convenience
#19860
+138
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
changed the title
TransactionRecord.*_json_dict_convenienceTransactionRecord.*_json_dict_convenience
Quexington
added
the
Changed
github-actions
bot
added
the
merge_conflict
…cord_json_dict_convenience
github-actions
bot
added
coverage-diff
and removed
merge_conflict
altendky
approved these changes
Aug 4, 2025
markelrod
approved these changes
Aug 5, 2025
|
Starttoaster
deleted the
quex.get_rid_of_tx_record_json_dict_convenience
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the concepts of regular and "convenient" transaction records. This soft type difference has been a source of headaches for a long time and causes a lot of pain when trying to add marshalling to the RPCs for endpoints that return transaction records.
The key to this change (apart from the prior memos change that laid the groundwork) is to add
to_addressas a mandatory field on theTransactionRecordobject. We already have some backwards compatibility code from when we added the timelock information to transaction records (#15915) so supporting parsing older transaction records from the DB is no big problem. This does technically break backwards compatibility for RPCs which take transaction records of which there is only one or two that I think are not commonly used (built for observer mode functionality that is somewhat uncommon). It adds a field to the responses as well, but added fields shouldn't constitute breaking changes.